Skip to content

perf(l1,l2): use keccak-asm #5182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

perf(l1,l2): use keccak-asm #5182

wants to merge 1 commit into from

Conversation

@Oppen
Copy link
Contributor

@Oppen Oppen commented Nov 4, 2025

Motivation

Description

Closes #issue_number

@github-actions github-actions bot added L1 Ethereum client L2 Rollup client performance labels Nov 4, 2025
@github-actions
Copy link

github-actions bot commented Nov 4, 2025

Lines of code report

Total lines added: 0
Total lines removed: 2
Total lines changed: 2

Detailed view 
+------------------------------------------+-------+------+
| File                                     | Lines | Diff |
+------------------------------------------+-------+------+
| ethrex/crates/common/utils.rs            | 62    | -1   |
+------------------------------------------+-------+------+
| ethrex/crates/vm/levm/src/precompiles.rs | 1602  | -1   |
+------------------------------------------+-------+------+

@github-actions
Copy link

github-actions bot commented Nov 4, 2025

Benchmark for d0326ea

Click to view benchmark
Test Base PR %
Trie/cita-trie insert 10k 35.6±1.19ms 36.6±1.75ms +2.81%
Trie/cita-trie insert 1k 3.5±0.01ms 3.6±0.17ms +2.86%
Trie/ethrex-trie insert 10k 31.4±0.71ms 27.2±0.84ms -13.38%
Trie/ethrex-trie insert 1k 2.8±0.01ms 2.2±0.05ms -21.43%

@github-actions
Copy link

github-actions bot commented Nov 4, 2025

Benchmark Results Comparison

No significant difference was registered for any benchmark run.

Detailed Results

Benchmark Results: BubbleSort

Command Mean [s] Min [s] Max [s] Relative
main_revm_BubbleSort 4.740 ± 0.014 4.718 4.768 1.52 ± 0.01
main_levm_BubbleSort 3.137 ± 0.022 3.120 3.196 1.01 ± 0.01
pr_revm_BubbleSort 4.771 ± 0.065 4.733 4.955 1.53 ± 0.02
pr_levm_BubbleSort 3.114 ± 0.024 3.089 3.158 1.00

Benchmark Results: ERC20Approval

Command Mean [s] Min [s] Max [s] Relative
main_revm_ERC20Approval 1.553 ± 0.003 1.548 1.558 1.42 ± 0.02
main_levm_ERC20Approval 1.094 ± 0.014 1.083 1.131 1.00
pr_revm_ERC20Approval 1.540 ± 0.005 1.534 1.549 1.41 ± 0.02
pr_levm_ERC20Approval 1.096 ± 0.013 1.085 1.121 1.00 ± 0.02

Benchmark Results: ERC20Mint

Command Mean [ms] Min [ms] Max [ms] Relative
main_revm_ERC20Mint 186.7 ± 0.7 185.9 188.0 1.10 ± 0.02
main_levm_ERC20Mint 169.4 ± 2.3 167.2 175.1 1.00
pr_revm_ERC20Mint 185.3 ± 0.8 184.2 186.6 1.09 ± 0.02
pr_levm_ERC20Mint 170.0 ± 0.6 169.2 171.2 1.00 ± 0.01

Benchmark Results: ERC20Transfer

Command Mean [ms] Min [ms] Max [ms] Relative
main_revm_ERC20Transfer 354.7 ± 1.9 353.0 358.8 1.27 ± 0.01
main_levm_ERC20Transfer 279.2 ± 2.8 276.3 284.5 1.00
pr_revm_ERC20Transfer 353.0 ± 5.1 350.2 366.9 1.26 ± 0.02
pr_levm_ERC20Transfer 280.5 ± 2.7 277.2 285.5 1.00 ± 0.01

Benchmark Results: Factorial

Command Mean [ms] Min [ms] Max [ms] Relative
main_revm_Factorial 234.7 ± 1.1 232.4 236.4 1.00
main_levm_Factorial 283.3 ± 0.7 282.3 284.9 1.21 ± 0.01
pr_revm_Factorial 235.3 ± 0.6 234.0 236.6 1.00 ± 0.01
pr_levm_Factorial 281.4 ± 0.9 280.4 283.6 1.20 ± 0.01

Benchmark Results: FactorialRecursive

Command Mean [s] Min [s] Max [s] Relative
main_revm_FactorialRecursive 1.643 ± 0.030 1.604 1.692 1.00
main_levm_FactorialRecursive 8.562 ± 0.034 8.512 8.619 5.21 ± 0.10
pr_revm_FactorialRecursive 1.655 ± 0.042 1.592 1.718 1.01 ± 0.03
pr_levm_FactorialRecursive 8.489 ± 0.051 8.417 8.572 5.17 ± 0.10

Benchmark Results: Fibonacci

Command Mean [ms] Min [ms] Max [ms] Relative
main_revm_Fibonacci 213.8 ± 0.3 213.3 214.4 1.00
main_levm_Fibonacci 265.7 ± 4.4 259.0 275.8 1.24 ± 0.02
pr_revm_Fibonacci 214.9 ± 1.9 213.1 219.2 1.01 ± 0.01
pr_levm_Fibonacci 264.0 ± 4.3 257.3 273.7 1.23 ± 0.02

Benchmark Results: FibonacciRecursive

Command Mean [ms] Min [ms] Max [ms] Relative
main_revm_FibonacciRecursive 863.3 ± 10.8 851.6 887.1 1.12 ± 0.02
main_levm_FibonacciRecursive 770.6 ± 4.3 765.3 775.2 1.00
pr_revm_FibonacciRecursive 861.7 ± 7.4 850.0 874.6 1.12 ± 0.01
pr_levm_FibonacciRecursive 784.6 ± 10.7 773.8 808.6 1.02 ± 0.01

Benchmark Results: ManyHashes

Command Mean [ms] Min [ms] Max [ms] Relative
main_revm_ManyHashes 12.4 ± 0.0 12.3 12.4 1.34 ± 0.00
main_levm_ManyHashes 9.3 ± 0.1 9.2 9.4 1.01 ± 0.01
pr_revm_ManyHashes 12.4 ± 0.0 12.3 12.5 1.34 ± 0.01
pr_levm_ManyHashes 9.2 ± 0.0 9.2 9.2 1.00

Benchmark Results: MstoreBench

Command Mean [ms] Min [ms] Max [ms] Relative
main_revm_MstoreBench 264.5 ± 3.5 261.2 270.9 1.03 ± 0.03
main_levm_MstoreBench 256.3 ± 1.2 254.4 258.1 1.00 ± 0.03
pr_revm_MstoreBench 265.3 ± 6.3 262.3 283.1 1.04 ± 0.04
pr_levm_MstoreBench 255.7 ± 7.0 250.7 275.2 1.00

Benchmark Results: Push

Command Mean [ms] Min [ms] Max [ms] Relative
main_revm_Push 297.6 ± 0.7 296.5 299.1 1.00
main_levm_Push 307.0 ± 3.5 305.2 316.8 1.03 ± 0.01
pr_revm_Push 299.9 ± 4.4 297.3 311.7 1.01 ± 0.01
pr_levm_Push 307.2 ± 2.6 305.1 314.0 1.03 ± 0.01

Benchmark Results: SstoreBench_no_opt

Command Mean [ms] Min [ms] Max [ms] Relative
main_revm_SstoreBench_no_opt 219.9 ± 0.4 219.3 220.5 2.44 ± 0.03
main_levm_SstoreBench_no_opt 90.1 ± 1.2 88.4 91.6 1.00
pr_revm_SstoreBench_no_opt 222.0 ± 4.4 219.7 234.2 2.46 ± 0.06
pr_levm_SstoreBench_no_opt 90.9 ± 3.0 88.3 98.0 1.01 ± 0.04

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

At least 2 approving reviews are required to merge this pull request.

Assignees

@Oppen Oppen

Labels

L1 Ethereum client L2 Rollup client performance

Projects

ethrex_l1
Status: No status
ethrex_l2
Status: No status
ethrex_performance
Status: Todo

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Oppen